Skip to content

fix: print rspack version instead of webpack's (fix #10189)#10190

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
tmadeira:fix-10189
Apr 25, 2025
Merged

fix: print rspack version instead of webpack's (fix #10189)#10190
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
tmadeira:fix-10189

Conversation

@tmadeira
Copy link
Contributor

@tmadeira tmadeira commented Apr 25, 2025

Summary

#10121 introduced a bug that makes rspack print webpack's version number rather than rspack's version number in rspack serve and rspack build (as reported in #10189).

This PR fixes it.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 25, 2025
@netlify
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit ae40387
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680b986d3b8d2600089545a1

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) April 25, 2025 21:11
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #10190 will not alter performance

Comparing tmadeira:fix-10189 (ae40387) with main (7f1a5e3)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan merged commit 3aecb75 into web-infra-dev:main Apr 25, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants