Skip to content

perf: trivial static variable improve#10113

Merged
quininer merged 1 commit intoweb-infra-dev:mainfrom
quininer:perf/trivial-static-improve
Apr 22, 2025
Merged

perf: trivial static variable improve#10113
quininer merged 1 commit intoweb-infra-dev:mainfrom
quininer:perf/trivial-static-improve

Conversation

@quininer
Copy link
Copy Markdown
Contributor

@quininer quininer commented Apr 22, 2025

Summary

This is mostly some trivial optimizations I found while investigating static usage, and I open a separate PR to submit it.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 22, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 395023e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680758fd9c318a0008507e20

@quininer quininer force-pushed the perf/trivial-static-improve branch 2 times, most recently from 2c71cac to 0bee681 Compare April 22, 2025 04:51
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10113 will not alter performance

Comparing quininer:perf/trivial-static-improve (395023e) with main (33eeb76)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@quininer quininer force-pushed the perf/trivial-static-improve branch 3 times, most recently from 12f55a7 to ae56871 Compare April 22, 2025 05:34
@quininer quininer force-pushed the perf/trivial-static-improve branch from ae56871 to 43678ea Compare April 22, 2025 06:32
@h-a-n-a h-a-n-a changed the title chore: trivial static variable improve perf: trivial static variable improve Apr 22, 2025
@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Apr 22, 2025
@quininer quininer force-pushed the perf/trivial-static-improve branch from 52860ea to fb0a06f Compare April 22, 2025 08:17
@quininer quininer enabled auto-merge (squash) April 22, 2025 08:21
@quininer quininer force-pushed the perf/trivial-static-improve branch from fb0a06f to 395023e Compare April 22, 2025 08:53
@quininer quininer merged commit 55f0016 into web-infra-dev:main Apr 22, 2025
30 checks passed
@quininer quininer deleted the perf/trivial-static-improve branch April 22, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SyMind SyMind SyMind approved these changes

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

No one assigned

Labels

release: performance release: performance related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quininer @SyMind @ahabhgk