Skip to content

fix(pnp): resolved wrong description file in yarn pnp mode#10111

Merged
stormslowly merged 1 commit intomainfrom
fix/pnp_desc_resolve_error
Apr 21, 2025
Merged

fix(pnp): resolved wrong description file in yarn pnp mode#10111
stormslowly merged 1 commit intomainfrom
fix/pnp_desc_resolve_error

Conversation

@stormslowly
Copy link
Copy Markdown
Contributor

@stormslowly stormslowly commented Apr 21, 2025

Summary

close #9967

the root cause is pnp-rs return wrong file_type when querying zip cached path.
Solved by update pnp-rs in rspack resolver.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 21, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 21, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 228acd4
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68064055558d5e0008d88662

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 21, 2025

CodSpeed Performance Report

Merging #10111 will not alter performance

Comparing fix/pnp_desc_resolve_error (228acd4) with main (ad4ba18)

Summary

✅ 11 untouched benchmarks

@stormslowly stormslowly merged commit a9c8a2d into main Apr 21, 2025
35 checks passed
@stormslowly stormslowly deleted the fix/pnp_desc_resolve_error branch April 21, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Broken CSS compilation on Yarn's PNP resolution engine

2 participants