Skip to content

fix(incremental): fallback when chunk depend on full hash#10110

Merged
ahabhgk merged 3 commits intomainfrom
fix-inc-chunk-hashes
Apr 22, 2025
Merged

fix(incremental): fallback when chunk depend on full hash#10110
ahabhgk merged 3 commits intomainfrom
fix-inc-chunk-hashes

Conversation

@ahabhgk
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk commented Apr 21, 2025

Summary

disable incremental for chunk hashes when chunk depend on full hash

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Apr 21, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 21, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5599700
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68073a4d5c91720008dfb46a

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 21, 2025

CodSpeed Performance Report

Merging #10110 will not alter performance

Comparing fix-inc-chunk-hashes (5599700) with main (3272992)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@ahabhgk ahabhgk marked this pull request as ready for review April 22, 2025 06:42
@ahabhgk ahabhgk requested a review from jerrykingxyz as a code owner April 22, 2025 06:42
@ahabhgk ahabhgk requested review from LingyuCoder and removed request for jerrykingxyz April 22, 2025 06:43
@ahabhgk ahabhgk enabled auto-merge (squash) April 22, 2025 06:47
@ahabhgk ahabhgk merged commit 57cdb73 into main Apr 22, 2025
30 checks passed
@ahabhgk ahabhgk deleted the fix-inc-chunk-hashes branch April 22, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants