Skip to content

fix: allow assignment of require identifier#10093

Merged
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/assign-require
Apr 20, 2025
Merged

fix: allow assignment of require identifier#10093
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/assign-require

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Apr 19, 2025

Summary

fix #10005

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 19, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 19, 2025

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5da814b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6803c5a46f972e0008a3c4b7
😎 Deploy Preview https://deploy-preview-10093--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 19, 2025

CodSpeed Performance Report

Merging #10093 will not alter performance

Comparing inottn:fix/assign-require (5da814b) with main (2838307)

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan requested a review from ahabhgk April 20, 2025 01:50
@ahabhgk ahabhgk merged commit 5397bda into web-infra-dev:main Apr 20, 2025
31 checks passed
@inottn inottn deleted the fix/assign-require branch April 20, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: production mode doesn't work if a version of formidable 1.x exists in the import graph for target: node

2 participants