Skip to content

fix: allow lazyCompilation.serverUrl to end with slash#10074

Merged
chenjiahan merged 4 commits intomainfrom
server_url_0417
Apr 18, 2025
Merged

fix: allow lazyCompilation.serverUrl to end with slash#10074
chenjiahan merged 4 commits intomainfrom
server_url_0417

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Apr 17, 2025 •
edited
Loading

Summary

  1. Allow the lazyCompilation.serverUrl option to end with slash (this is a common practice as output.publicPath should ends with a slash):
// rspack.config.mjs
export default {
  experiments: {
    lazyCompilation: {
      serverUrl: 'http://localhost:3000/',
    }
  }
};
  1. Improve JSDoc and documentation for the lazy compilation options.
  2. Remove the outdated backend option from lazy compilation test cases.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 17, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 1327625
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68011b2cc3e387000881e263
😎 Deploy Preview https://deploy-preview-10074--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from JSerFeng April 17, 2025 15:16
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 17, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #10074 will not alter performance

Comparing server_url_0417 (1327625) with main (f9c055f)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan changed the title fix(lazyCompilation): allow serverUrl option to end with slash fix: allow lazyCompilation.serverUrl to end with slash Apr 18, 2025
@chenjiahan chenjiahan changed the title fix: allow lazyCompilation.serverUrl to end with slash fix: allow lazyCompilation.serverUrl to end with slash Apr 18, 2025
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 18, 2025
@chenjiahan chenjiahan merged commit 57b28d2 into main Apr 18, 2025
36 of 41 checks passed
@chenjiahan chenjiahan deleted the server_url_0417 branch April 18, 2025 03:21
@renovate renovate bot mentioned this pull request May 25, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjiahan @JSerFeng