Skip to content

fix: hmr should not include unchanged module when adding a new runtime#10061

Merged
ahabhgk merged 7 commits intomainfrom
more-hmr-test
Apr 21, 2025
Merged

fix: hmr should not include unchanged module when adding a new runtime#10061
ahabhgk merged 7 commits intomainfrom
more-hmr-test

Conversation

@ahabhgk
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk commented Apr 17, 2025

Summary

fix thing and enable more tests

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 17, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 17, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit a7f8c49
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6805d01f47a1920008a1bd1f
😎 Deploy Preview https://deploy-preview-10061--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #10061 will not alter performance

Comparing more-hmr-test (a7f8c49) with main (b854e57)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@ahabhgk ahabhgk changed the title test: pass more hmr tests fix: hmr should not include unchanged module when adding a new runtime Apr 17, 2025
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 17, 2025
@ahabhgk ahabhgk enabled auto-merge (squash) April 17, 2025 09:20
@ahabhgk ahabhgk requested a review from LingyuCoder April 17, 2025 09:20
LingyuCoder
LingyuCoder previously approved these changes Apr 17, 2025
@ahabhgk ahabhgk merged commit b0a594f into main Apr 21, 2025
27 checks passed
@ahabhgk ahabhgk deleted the more-hmr-test branch April 21, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants