Skip to content

fix(incremental): revoked module shouldn't exist in built modules#10051

Merged
JSerFeng merged 1 commit intomainfrom
fix-inc-panic-built-revoked-module
Apr 16, 2025
Merged

fix(incremental): revoked module shouldn't exist in built modules#10051
JSerFeng merged 1 commit intomainfrom
fix-inc-panic-built-revoked-module

Conversation

@ahabhgk
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk commented Apr 16, 2025

Summary

fix panic for revoke module also exists in built modules

also enable e2e test for incremental

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from jerrykingxyz as a code owner April 16, 2025 06:58
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 16, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 16, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8180ae5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67ff558fed31780008d8b8ea

@ahabhgk ahabhgk force-pushed the fix-inc-panic-built-revoked-module branch from a426ec2 to 8180ae5 Compare April 16, 2025 07:00
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 16, 2025

CodSpeed Performance Report

Merging #10051 will not alter performance

Comparing fix-inc-panic-built-revoked-module (8180ae5) with main (2747857)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@JSerFeng JSerFeng merged commit 2491704 into main Apr 16, 2025
32 of 33 checks passed
@JSerFeng JSerFeng deleted the fix-inc-panic-built-revoked-module branch April 16, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants