Skip to content

fix: failed to resolve tinypool when using parallel loader#10040

Merged
chenjiahan merged 1 commit intomainfrom
resolve_tinypool_0415
Apr 15, 2025
Merged

fix: failed to resolve tinypool when using parallel loader#10040
chenjiahan merged 1 commit intomainfrom
resolve_tinypool_0415

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Fix failed to resolve tinypool when using parallel loader:

Screenshot 2025-04-15 at 22 47 25

The tinypool is imported with import() and directory import is not supported in this case. We should import the full module path.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from h-a-n-a April 15, 2025 14:53
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Apr 15, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2c452cb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67fe72e9f7a98c0008514fde

@chenjiahan chenjiahan enabled auto-merge (squash) April 15, 2025 14:57
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #10040 will not alter performance

Comparing resolve_tinypool_0415 (2c452cb) with main (c5dc7b6)

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan merged commit 1bb3a1d into main Apr 15, 2025
31 checks passed
@chenjiahan chenjiahan deleted the resolve_tinypool_0415 branch April 15, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants