Skip to content

fix: remove progressbar instance when closing compiler#10034

Merged
LingyuCoder merged 2 commits intomainfrom
fix/close-server-progress
Apr 15, 2025
Merged

fix: remove progressbar instance when closing compiler#10034
LingyuCoder merged 2 commits intomainfrom
fix/close-server-progress

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Apr 15, 2025

Summary

fix #8444

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested review from Copilot and h-a-n-a April 15, 2025 08:44
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 15, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit a1d8f0a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67fe2d59fb058b00086c92a5
😎 Deploy Preview https://deploy-preview-10034--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copilot AI reviewed Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/rspack/src/Compiler.ts:711

  • [nitpick] Using the non-null assertion operator 'instance!' may hide potential null scenarios. Consider adding an explicit null-check or a clarifying comment ensuring that instance must be non-null at this point.
instance!.close()

crates/rspack_core/src/compiler/mod.rs:537

  • Ensure that adequate tests exist for the new CompilerClose hook to verify its behavior in different shutdown scenarios.
pub async fn close(&self) -> Result<()> {

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10034 will degrade performances by 25.79%

Comparing fix/close-server-progress (a1d8f0a) with main (97715b5)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ Traverse module graph by dependencies 613.1 µs 826.3 µs -25.79%

@LingyuCoder LingyuCoder enabled auto-merge (squash) April 15, 2025 10:08
@LingyuCoder LingyuCoder merged commit e8b6ddf into main Apr 15, 2025
26 of 27 checks passed
@LingyuCoder LingyuCoder deleted the fix/close-server-progress branch April 15, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: The previous progress bar was not destroyed when compiler closed & rerun

3 participants

@LingyuCoder @h-a-n-a