fix: skip everything if there's no rule#271
Merged
Conversation
✅ Deploy Preview for rslint canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the linter performance by skipping file processing when no rules are applicable to a file. This avoids unnecessary comment parsing and disable manager creation for files that won't be linted.
Key Changes
- Early exit from file processing loop when no rules are found for a file
- Defers expensive comment parsing until rules are confirmed to exist
- Avoids creating disable manager objects for files without applicable rules
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
hardfist
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also good for the performance I think.