Conversation
✅ Deploy Preview for rslint canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the VS Code extension's status bar to display the currently configured binary path for better user visibility and debugging. The change replaces the generic "rslint" text with a more informative display that shows which binary is being used.
- Replaces the static status bar text with dynamic content showing the configured binPath
- Removes the warning background color styling from the status bar
- Imports the RslintBinPath type for proper type safety
| const binPathConfig = vscode.workspace | ||
| .getConfiguration() | ||
| .get<RslintBinPath>('rslint.binPath')!; | ||
| statusBar.text = `Rslint(${binPathConfig})`; |
There was a problem hiding this comment.
Using the non-null assertion operator (!) assumes the configuration value will always exist. Consider handling the case where 'rslint.binPath' is undefined to prevent potential runtime errors.
Suggested change
| statusBar.text = `Rslint(${binPathConfig})`; | |
| .get<RslintBinPath>('rslint.binPath'); | |
| statusBar.text = `Rslint(${binPathConfig ?? 'not set'})`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show binPath in statusBar tooltip for better understanding