Skip to content

chore: fix release tag push#266

Merged
hardfist merged 5 commits intomainfrom
chore/fix_ci_tag_push
Aug 15, 2025
Merged

chore: fix release tag push#266
hardfist merged 5 commits intomainfrom
chore/fix_ci_tag_push

Conversation

@stormslowly
Copy link
Copy Markdown
Contributor

@stormslowly stormslowly commented Aug 14, 2025

  1. use git push origin $tag to push local tag to remote in release.
  2. remove self hosted windows runner

Copilot AI review requested due to automatic review settings August 14, 2025 14:40
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 14, 2025

Deploy Preview for rslint canceled.

Name Link
🔨 Latest commit 29d210c
🔍 Latest deploy log https://app.netlify.com/projects/rslint/deploys/689eeacded917e0008ec1f9c

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the release workflow where git tag creation was being echoed instead of executed, and adds the go-lint job as a dependency for the CI completion check.

  • Removes the debug echo statement and properly executes the git tag command with a message
  • Adds go-lint job dependency to ensure all lint checks complete before marking CI as done

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/release.yml Fixes git tag creation by removing echo statement and adding tag message
.github/workflows/ci.yml Adds go-lint job dependency to CI completion gate

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread .github/workflows/release.yml
@stormslowly stormslowly force-pushed the chore/fix_ci_tag_push branch from 252df93 to 331569e Compare August 14, 2025 15:49
@stormslowly stormslowly marked this pull request as draft August 14, 2025 15:55
@stormslowly stormslowly marked this pull request as ready for review August 15, 2025 08:22
@hardfist hardfist merged commit 301bc7e into main Aug 15, 2025
18 of 22 checks passed
@hardfist hardfist deleted the chore/fix_ci_tag_push branch August 15, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants