Conversation
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ba16560 to
8f2e02b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a rules page to the website to track the implementation status of ESLint rules being ported to rslint. The page displays an interactive table showing rule names, groups, implementation status, and failing test cases.
Key changes:
- Creates a React component that fetches and displays rule manifest data
- Updates the website icon from a banner to the SVG logo
- Adds a new rules index page that renders the manifest component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| website/rspress.config.ts | Updates the website icon from PNG banner to SVG logo |
| website/docs/rules/rule-manifest.tsx | Creates interactive React component for displaying rule implementation status with filtering and statistics |
| website/docs/rules/index.mdx | Adds rules page entry point that imports and renders the manifest component |
| > | ||
| •{' '} | ||
| <a | ||
| href={`https://github.com/web-infra-dev/rslint/blob/main/${failingCase.url}`} |
There was a problem hiding this comment.
The GitHub URL is hardcoded. Consider extracting it as a constant or deriving it from the RULE_MANIFEST_URL to maintain consistency if the repository URL changes.
| href={`https://github.com/web-infra-dev/rslint/blob/main/${failingCase.url}`} | |
| href={`${GITHUB_BASE_URL}${failingCase.url}`} |
| transition: all 0.2s ease-in-out; | ||
| } | ||
| `} | ||
| </style> |
There was a problem hiding this comment.
Inline styles in a <style> tag within a React component is not recommended. Consider using CSS modules, styled-components, or moving styles to a separate CSS file for better maintainability.
| </style> |
add rules page to track port status https://rslint.rs/rules