refactor: move lsp implmentation into internal#246
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the LSP implementation by moving it from the main command package into a dedicated internal package structure. The changes align the codebase with the TypeScript-Go project structure and improve code organization.
- Moves LSP server implementation from
cmd/rslint/lsp.gotointernal/lsp/server.go - Creates a new
internal/lsppackage with proper encapsulation - Updates package references and imports to use the new structure
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
internal/lsp/service.go |
Empty file removed during the refactoring |
internal/lsp/server_test.go |
Package declaration corrected from main to lsp |
internal/lsp/server.go |
Complete LSP server implementation moved from cmd package |
internal/ls/api.go |
New empty package file created |
cmd/rslint/lsp.go |
Simplified to use the new internal/lsp package |
5e22fb4 to
005be65
Compare
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the lsp implementation into internal/lsp and align with tsgo structure