Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds macOS CI support to the build pipeline by extending the test matrix to include macOS and Windows runners alongside the existing Linux setup. The changes also include cross-platform compatibility improvements for file path handling.
- Added macOS and Windows runners to the CI test matrix
- Updated file path handling to use cross-platform utilities
- Restricted certain CI steps (linting, formatting, spell checking) to Linux only to avoid redundancy
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Extended test matrix to include macOS and Windows runners, conditionally run certain steps only on Linux |
.github/actions/setup-go/action.yml |
Added Linux-only condition for Go module cache cleanup |
internal/config/config.go |
Replaced custom path normalization with TypeScript-go utilities and updated doublestar API calls |
internal/config/cwd_test.go |
Updated doublestar API call from PathMatch to Match |
cmd/rslint/lsp.go |
Replaced string concatenation with filepath.Join for cross-platform path handling |
cmd/rslint/api.go |
Added path normalization for file contents in IPC handler |
9b8edb9 to
82b4b8c
Compare
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add mac ci