Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This refactor aligns the LSP implementation with the typescript-go project service architecture, moving away from manual program creation to using the more sophisticated project service.
- Refactors LSP server to use
project.Serviceinstead of manually creating TypeScript programs - Introduces
RunLinterInProgramfunction to enable single-program linting - Simplifies configuration discovery by removing file-path-based search strategies
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
internal/utils/utils.go |
Adds generic Must utility function for error handling |
internal/linter/linter.go |
Extracts RunLinterInProgram from existing logic and refactors for project service integration |
cmd/rslint/lsp_test.go |
Updates test to match simplified findRslintConfig signature |
cmd/rslint/lsp.go |
Major refactor to use project service, simplifies configuration discovery and file handling |
cmd/rslint/cmd.go |
Adds empty line in function call (formatting change) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Aug 15, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
align lsp implementation with tsgo for better consistency behavior