Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a custom uriToPath function with the standard ls.DocumentUriToFilename function to improve Windows compatibility for URI-to-file-path conversion in the LSP server implementation.
Key changes:
- Replaces custom URI parsing logic with the TypeScript-Go library's built-in function
- Comments out unused function declarations in the shim layer
- Updates function signatures to use proper
lsproto.DocumentUritypes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
shim/ls/shim.go |
Comments out unused function declarations and maintains the DocumentURIToFileName export |
go.mod |
Adds dependency on github.com/microsoft/typescript-go/shim/ls module |
cmd/rslint/lsp.go |
Replaces custom uriToPath implementation with ls.DocumentURIToFileName and updates call sites |
| type Definition = ls.Definition | ||
| //go:linkname DeprecateSortText github.com/microsoft/typescript-go/internal/ls.DeprecateSortText | ||
| func DeprecateSortText(original ls.sortText) ls.sortText | ||
| ////go:linkname DeprecateSortText github.com/microsoft/typescript-go/internal/ls.DeprecateSortText |
There was a problem hiding this comment.
The comment syntax is inconsistent. Use // instead of //// for commenting out the go:linkname directive.
Suggested change
| ////go:linkname DeprecateSortText github.com/microsoft/typescript-go/internal/ls.DeprecateSortText | |
| //go:linkname DeprecateSortText github.com/microsoft/typescript-go/internal/ls.DeprecateSortText |
| func FileNameToDocumentURI(fileName string) lsproto.DocumentUri | ||
| //go:linkname GetCompletionItemData github.com/microsoft/typescript-go/internal/ls.GetCompletionItemData | ||
| func GetCompletionItemData(item *lsproto.CompletionItem) (*ls.itemData, error) | ||
| ////go:linkname GetCompletionItemData github.com/microsoft/typescript-go/internal/ls.GetCompletionItemData |
There was a problem hiding this comment.
The comment syntax is inconsistent. Use // instead of //// for commenting out the go:linkname directive.
Suggested change
| ////go:linkname GetCompletionItemData github.com/microsoft/typescript-go/internal/ls.GetCompletionItemData | |
| //go:linkname GetCompletionItemData github.com/microsoft/typescript-go/internal/ls.GetCompletionItemData |
| func NewLanguageService(host ls.Host) *ls.LanguageService | ||
| //go:linkname NewSymbolAndEntries github.com/microsoft/typescript-go/internal/ls.NewSymbolAndEntries | ||
| func NewSymbolAndEntries(kind ls.definitionKind, node *ast.Node, symbol *ast.Symbol, references []*ls.referenceEntry) *ls.SymbolAndEntries | ||
| ////go:linkname NewSymbolAndEntries github.com/microsoft/typescript-go/internal/ls.NewSymbolAndEntries |
There was a problem hiding this comment.
The comment syntax is inconsistent. Use // instead of //// for commenting out the go:linkname directive.
Suggested change
| ////go:linkname NewSymbolAndEntries github.com/microsoft/typescript-go/internal/ls.NewSymbolAndEntries | |
| //go:linkname NewSymbolAndEntries github.com/microsoft/typescript-go/internal/ls.NewSymbolAndEntries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use ls.DocumentUriToFilename for UriToPath for better windows compat