Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the no-implied-eval test for the TypeScript-ESLint rule by adding it to the test configuration and creating the corresponding snapshot file with expected test outputs.
- Adds the
no-implied-evaltest to the active test suite configuration - Creates comprehensive test snapshots with 22 test cases covering various implied eval scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/rslint-test-tools/rstest.config.mts |
Adds the no-implied-eval test file to the test configuration array |
packages/rslint-test-tools/tests/typescript-eslint/rules/__snapshots__/no-implied-eval.test.ts.snap |
Creates snapshot file with expected test outputs for 22 invalid test cases covering setTimeout, setInterval, Function constructor, and other implied eval scenarios |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.