Merged
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
It feels a bit personal, but do we really need to use a strong red color for the documentation link? It gives off an "error" vibe, even though it's very eye-catching. 🤔 |
Member
Author
fi3ework
approved these changes
May 15, 2025
Member
There was a problem hiding this comment.
In the second image, rspack.dev has a very highly saturated red, especially compared to the other two links (vue and nitro). I'm not a design professional, but I believe a lower saturation color would work better. Never mind, we can ask the team's designer for suggestions. 😀
Member
Author
|
Reduced contrast in rstackjs/rstack-doc-ui#37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Related: https://github.com/rspack-contrib/rstack-doc-ui/releases/tag/v1.9.0
Before
After
Checklist