Skip to content

chore(CI): correct permissions for issue labeler#596

Merged
Timeless0911 merged 1 commit intomainfrom
update_github_config_1224
Dec 24, 2024
Merged

chore(CI): correct permissions for issue labeler#596
Timeless0911 merged 1 commit intomainfrom
update_github_config_1224

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Dec 24, 2024

Summary

  1. Since the pr-labeler workflow adds labels to pull requests, it needs the pull-requests: write permission.

image

  1. The GitHub issue types work well and we can remove the issue label to reduce duplicated information.

Related Links

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token#overview

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #596 will not alter performance

Comparing update_github_config_1224 (95d55b9) with main (4416f02)

Summary

✅ 5 untouched benchmarks

@chenjiahan chenjiahan requested a review from fi3ework December 24, 2024 06:29
@Timeless0911 Timeless0911 merged commit 4066395 into main Dec 24, 2024
@Timeless0911 Timeless0911 deleted the update_github_config_1224 branch December 24, 2024 06:42
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fi3ework fi3ework fi3ework approved these changes

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenjiahan @fi3ework @Timeless0911