Skip to content

fix: pass server config to Rsbuild#584

Merged
Timeless0911 merged 3 commits intomainfrom
fix/should-pass-server
Dec 20, 2024
Merged

fix: pass server config to Rsbuild#584
Timeless0911 merged 3 commits intomainfrom
fix/should-pass-server

Conversation

@Timeless0911
Copy link
Copy Markdown
Contributor

@Timeless0911 Timeless0911 commented Dec 19, 2024

Summary

We should pass server config to Rsbuild since mf dev and some publicDir feature need to configure it.

Related Links

fix: #583

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 19, 2024

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 58662cc
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67642258c8e34d0008258952
😎 Deploy Preview https://deploy-preview-584--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #584 will not alter performance

Comparing fix/should-pass-server (e168e55) with main (e667662)

Summary

✅ 5 untouched benchmarks

fi3ework
fi3ework reviewed Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to document out public dir https://rsbuild.dev/zh/guide/basic/static-assets#public-%E7%9B%AE%E5%BD%95 in Rslib document as well. For now, there's not any word for it, and user won't know it without reading Rsbuild's doc.

@Timeless0911
Copy link
Copy Markdown
Contributor Author

Timeless0911 commented Dec 19, 2024

I think we need to document out public dir https://rsbuild.dev/zh/guide/basic/static-assets#public-%E7%9B%AE%E5%BD%95 in Rslib document as well. For now, there's not any word for it, and user won't know it without reading Rsbuild's doc.

We can introduce it in assets chapter after we support all assets feature well.

@fi3ework fi3ework mentioned this pull request Dec 20, 2024
Closed
6 tasks
@fi3ework fi3ework force-pushed the fix/should-pass-server branch from ce61417 to e168e55 Compare December 20, 2024 04:16
@fi3ework fi3ework enabled auto-merge (squash) December 20, 2024 04:16
@Timeless0911 Timeless0911 merged commit b7a74f8 into main Dec 20, 2024
@Timeless0911 Timeless0911 deleted the fix/should-pass-server branch December 20, 2024 05:09
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Merged
@Timeless0911 Timeless0911 mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fi3ework fi3ework fi3ework approved these changes

@9aoy 9aoy 9aoy approved these changes

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

3 participants

@Timeless0911 @fi3ework @9aoy