fix(create-rslib): set tsconfig jsx to react-jsx#516
Merged
Conversation
CodSpeed Performance ReportMerging #516 will improve performances by 76.95%Comparing Summary
Benchmarks breakdown
|
fi3ework
reviewed
Dec 4, 2024
Member
There was a problem hiding this comment.
This was for compatibility reasons. As we didn't require a minimal react >= 16.14.0 in peer dep.
I checked some mainstream React libraries:
- antd: classic
- @tanstack/react-query: automatic
- react-router: classic
- mobx-react: classic
- framer-motion: automatic
I believe moving to the new JSX runtime for new libraries is a positive step. This change can help avoid potential migration costs in the future.
Member
Author
|
Agreed, I have updated |
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fi3ework
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React >= 17 should use
react-jsxinstead ofreact.Related Links
https://www.typescriptlang.org/tsconfig/#jsx
Checklist