chore: remove duplicated workspace definitions#306
Merged
Timeless0911 merged 1 commit intomainfrom Oct 17, 2024
Merged
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #306 will improve performances by 12.81%Comparing Summary
Benchmarks breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially revert #302. After #302, we can't execute
npx rslib buildunder any integrations tests cases.This PR doesn't revert the goal of #302, just remove the
workspacesfield of the root package.json which is the monorepo field for npm(https://docs.npmjs.com/cli/v7/using-npm/workspaces), this also helps keep single source of truth of the monorepo definition (pnpm-workspace.yaml).changesets uses https://github.com/Thinkmill/manypkg to find packages in a monorepo under the hood so it could correct resolve pnpm-workspace.yaml. check-dependency-version-consistency could also read it https://github.com/bmish/check-dependency-version-consistency#usage.
Related Links
Checklist