Skip to content

chore: should check deps of all package.json#302

Merged
Timeless0911 merged 3 commits intomainfrom
chore/check-deps
Oct 17, 2024
Merged

chore: should check deps of all package.json#302
Timeless0911 merged 3 commits intomainfrom
chore/check-deps

Conversation

@Timeless0911
Copy link
Copy Markdown
Contributor

@Timeless0911 Timeless0911 commented Oct 17, 2024 •
edited
Loading

Summary

Now check-dependency-version-consistency only works in packages/* folder, we need to cover all of the packages folder.

Since both changeset and check-dependency-version-consistency will read workspaces field in package.json, this PR have done such thing:

  • Add more packages glob pattern to workspaces.packages
  • Config privatePackages field of .changeset/config.json to disable bump private packages
  • Modify the test script of tests/integration/cli/index.test.ts since after adding tests/** to workspaces.packages field, npx rslib inspect will report an error
npm ERR! could not determine executable to run

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 requested a review from fi3ework October 17, 2024 06:34
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit c5ce856
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/6710bc380d5f9d000957b9ef
😎 Deploy Preview https://deploy-preview-302--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #302 will not alter performance

Comparing chore/check-deps (c5ce856) with main (f4bb341)

Summary

✅ 4 untouched benchmarks

fi3ework
fi3ework reviewed Oct 17, 2024
View reviewed changes
chenjiahan
chenjiahan reviewed Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary pls 👀

@Timeless0911
Copy link
Copy Markdown
Contributor Author

Timeless0911 commented Oct 17, 2024

PR Summary pls 👀

Just editing before

@Timeless0911 Timeless0911 merged commit f9f1751 into main Oct 17, 2024
@Timeless0911 Timeless0911 deleted the chore/check-deps branch October 17, 2024 07:34
@fi3ework fi3ework mentioned this pull request Oct 17, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan left review comments

@fi3ework fi3ework fi3ework approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Timeless0911 @chenjiahan @fi3ework