Skip to content

feat: support "umd" format#299

Merged
Timeless0911 merged 5 commits intomainfrom
umd
Oct 17, 2024
Merged

feat: support "umd" format#299
Timeless0911 merged 5 commits intomainfrom
umd

Conversation

@fi3ework
Copy link
Copy Markdown
Member

@fi3ework fi3ework commented Oct 16, 2024 •
edited
Loading

Summary

TODO:

umdModuleName lacks some advanced features:

  1. non string type
  2. auto transform to camel case

We might implement them after understand why they're supported in https://modernjs.dev/module-tools/api/config/build-config.html#umdglobals.

update:

  1. Don't need to support auto transform to camel case, it was a limitation when implement with swc.
  2. non string type might support it.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@fi3ework fi3ework requested a review from Timeless0911 October 16, 2024 09:00
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 4532096
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/670f89065ea9ca0008a8b8f1
😎 Deploy Preview https://deploy-preview-299--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 16, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #299 will create unknown performance changes

Comparing umd (e9b87d3) with main (96f5983)

Summary

🆕 4 new benchmarks
⁉️ 3 (👁 3) dropped benchmarks

Benchmarks breakdown

Benchmark main umd Change
🆕 examples/express-plugin N/A 107 ms N/A
🆕 examples/react-component-bundle N/A 156.6 ms N/A
🆕 examples/react-component-bundle-false N/A 183.1 ms N/A
🆕 examples/react-component-umd N/A 162.9 ms N/A
👁 examples/express-plugin 106 ms N/A N/A
👁 examples/react-component-bundle 155.3 ms N/A N/A
👁 examples/react-component-bundle-false 169.6 ms N/A N/A

@fi3ework
Copy link
Copy Markdown
Member Author

fi3ework commented Oct 16, 2024

I think I need to split the UMD config from the current example as it will mix the benchmarks all together.

@fi3ework fi3ework force-pushed the umd branch 2 times, most recently from 4532096 to 4c12b6f Compare October 16, 2024 09:46
Timeless0911
Timeless0911 reviewed Oct 17, 2024
View reviewed changes
fi3ework and others added 4 commits October 17, 2024 14:15
@fi3ework @Timeless0911
Update examples/react-component-umd/README.md
063022d 
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
@fi3ework @Timeless0911
Update examples/react-component-umd/README.md
ea38be4 
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
@fi3ework @Timeless0911
Update packages/core/src/config.ts
158acce 
Co-authored-by: Timeless0911 <50201324+Timeless0911@users.noreply.github.com>
@fi3ework
up
e9b87d3
@Timeless0911 Timeless0911 merged commit f4bb341 into main Oct 17, 2024
@Timeless0911 Timeless0911 deleted the umd branch October 17, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

No one assigned

Labels

change: feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fi3ework @Timeless0911