feat: support Module Federation format by nyqykk · Pull Request #240 · web-infra-dev/rslib

nyqykk · 2024-09-27T03:51:05Z

Summary

Add format called 'mf' to build Module Federation assets and add example for both host and remote scene in rslib

closes: #212

Checklist

Tests updated (or not required).
Documentation updated (or not required).

…ample of rslib pkg

netlify · 2024-09-27T03:52:07Z

✅ Deploy Preview for rslib ready!

Name	Link
🔨 Latest commit	`f28da36`
🔍 Latest deploy log	https://app.netlify.com/sites/rslib/deploys/6712286d6227610008f8aa00
😎 Deploy Preview	https://deploy-preview-240--rslib.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

examples/mf-host/@mf-types/index.d.ts

packages/plugin-module-federation/package.json

packages/plugin-module-federation/src/cli/index.ts

fi3ework · 2024-10-10T03:41:50Z

@nyqykk Let’s keep pushing this PR.

nyqykk · 2024-10-10T03:53:46Z

@nyqykk Let’s keep pushing this PR.

i write a rsbuild plugin in mf repo, for both app project and rslib which is build by rsbuild, so this branch will be changed
module-federation/core#3062

.changeset/sharp-kiwis-own.md

examples/mf-host/.gitignore

examples/mf-host/package.json

examples/mf-remote/package.json

examples/react-component/package.json

packages/plugin-dts/package.json

packages/core/src/config.ts

examples/mf-remote/rsbuild.config.ts

codspeed-hq · 2024-10-11T08:24:21Z

CodSpeed Performance Report

Merging #240 will improve performances by 69.49%

_{Comparing feat/support-mf (f28da36) with main (760968b)}

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

	Benchmark	`main`	`feat/support-mf`	Change
🆕	`examples/module-federation/mf-react-component`	N/A	356 ms	N/A
⚡	`examples/react-component-bundle-false`	298.2 ms	176 ms	+69.49%

Timeless0911

LGTM for the initial implementation, we can continue to iterate and improve it in later PRs.

packages/core/src/config.ts

examples/module-federation/mf-react-component/README.md

examples/module-federation/mf-react-component/package.json

packages/core/src/utils/helper.ts

website/docs/en/guide/advanced/module-federation.mdx

website/docs/zh/guide/advanced/module-federation.mdx

website/docs/en/guide/advanced/module-federation.mdx

packages/core/src/config.ts

.changeset/sharp-kiwis-own.md

packages/core/src/config.ts

examples/module-federation/mf-host/README.md

examples/module-federation/mf-remote/README.md

fi3ework · 2024-10-18T08:26:08Z

Generally LGTM. 👍

fi3ework · 2024-10-18T08:47:38Z

Append examples/module-fedration/mf-react-component to https://github.com/web-infra-dev/rslib/blob/main/tests/benchmark/index.bench.ts then we're good to merge.

You could remove the 'esm' and 'cjs' lib from the config like what disableDts does. This could help us only foucs on measure the benchmark of MF bundling. disableDts should also be applied as well.

website/docs/zh/guide/start/index.mdx

tests/benchmark/index.bench.ts

fi3ework · 2024-10-18T09:35:24Z

The benchmark shows examples/react-component-bundle-false got improved, but it should be irrelevant. cc @SoonIter any idea?

fi3ework · 2024-10-18T09:35:56Z

Great work!

nyqykk added 3 commits September 23, 2024 11:37

feat(mf): support mf format and add example

2eee0c6

chore: remove useless change

b452af3

feat: add mf rsbuild plugin for rslib and add both host and remote ex…

d4ffe70

…ample of rslib pkg

nyqykk added 2 commits September 27, 2024 12:00

chore: resolve conflict

07b0db0

chore: add changeset

43f5a14

fi3ework marked this pull request as draft September 27, 2024 04:13

chenjiahan reviewed Sep 27, 2024

View reviewed changes

examples/mf-host/@mf-types/index.d.ts Outdated Show resolved Hide resolved

packages/plugin-module-federation/package.json Outdated Show resolved Hide resolved

packages/plugin-module-federation/src/cli/index.ts Outdated Show resolved Hide resolved

nyqykk added 2 commits September 27, 2024 16:55

chore: remove judgement

0cd4b3c

chore: modify readme

023444f

nyqykk added 2 commits October 10, 2024 14:37

chore: use mf rsbuild plugin to remove rslib repo plugin

e0e6fa3

chore: sync main code

c0569a4

Timeless0911 reviewed Oct 10, 2024

View reviewed changes

.changeset/sharp-kiwis-own.md Outdated Show resolved Hide resolved

Timeless0911 reviewed Oct 10, 2024

View reviewed changes

packages/core/src/config.ts Show resolved Hide resolved

2heal1 reviewed Oct 10, 2024

View reviewed changes

examples/mf-remote/rsbuild.config.ts Show resolved Hide resolved

nyqykk added 5 commits October 11, 2024 15:00

chore: resolve conversation in issue

adbe668

chore: remove useless

1296f93

chore: remove empty folder

04cd00e

chore: sync code

a16c82e

chore: revert change

c0f84a4

chore: rename some folder

49f834f

nyqykk marked this pull request as ready for review October 11, 2024 08:39

Timeless0911 changed the title ~~[WIP]feat: support Module Federation format~~ feat: support Module Federation format Oct 11, 2024

github-actions bot added the change: feat label Oct 11, 2024

Timeless0911 previously approved these changes Oct 11, 2024

View reviewed changes

fi3ework reviewed Oct 11, 2024

View reviewed changes

packages/core/src/config.ts Outdated Show resolved Hide resolved

chenjiahan reviewed Oct 16, 2024

View reviewed changes

examples/module-federation/mf-react-component/README.md Outdated Show resolved Hide resolved

chenjiahan reviewed Oct 16, 2024

View reviewed changes

website/docs/en/guide/advanced/module-federation.mdx Outdated Show resolved Hide resolved

Timeless0911 reviewed Oct 17, 2024

View reviewed changes

packages/core/src/config.ts Show resolved Hide resolved

nyqykk added 6 commits October 18, 2024 11:15

chore: modify issues

fc538af

chore: solve conversation issue

e470fc4

chore: change rsbuild plugin to dev dep

82511cc

chore: revert modify semver version

51cd7ed

chore: use 1.x to remove specific version

89b5a1e

chore: fix pnpm lint check-dependency-version error

784fc3b

nyqykk mentioned this pull request Oct 18, 2024

[Feature]: Modern.js Module build support module federation web-infra-dev/modern.js#6401

Closed

nyqykk added 3 commits October 18, 2024 15:45

chore: revert version change

30571f1

chore: update lock

454ac08

chore: revert change dts plugin package.json

696ed9d

nyqykk enabled auto-merge (squash) October 18, 2024 07:55

chore: do not specify rsbuild plugin version

c052d93

fi3ework reviewed Oct 18, 2024

View reviewed changes

nyqykk added 2 commits October 18, 2024 16:29

chore: add introduction for mf example

4720213

chore: use external type map to simplify code

5cbadc4

chore: add benchmark

ea26ce3

Timeless0911 reviewed Oct 18, 2024

View reviewed changes

website/docs/zh/guide/start/index.mdx Outdated Show resolved Hide resolved

fi3ework reviewed Oct 18, 2024

View reviewed changes

tests/benchmark/index.bench.ts Outdated Show resolved Hide resolved

chore: just keep mf format in benchmark

f28da36

fi3ework approved these changes Oct 18, 2024

View reviewed changes

nyqykk merged commit d362cdb into main Oct 18, 2024

nyqykk deleted the feat/support-mf branch October 18, 2024 09:35

Uh oh!

Conversation

nyqykk commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Links

Checklist

Uh oh!

netlify bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rslib ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fi3ework commented Oct 10, 2024

Uh oh!

nyqykk commented Oct 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #240 will improve performances by 69.49%

Summary

Benchmarks breakdown

Uh oh!

Timeless0911 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fi3ework commented Oct 18, 2024

Uh oh!

fi3ework commented Oct 18, 2024

Uh oh!

Uh oh!

Uh oh!

fi3ework commented Oct 18, 2024

Uh oh!

fi3ework commented Oct 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nyqykk commented Sep 27, 2024 •

edited

Loading

netlify bot commented Sep 27, 2024 •

edited

Loading

codspeed-hq bot commented Oct 11, 2024 •

edited

Loading