fix(shims): import.meta.url not being removed by tree-shaking#1463
Merged
Timeless0911 merged 4 commits intoweb-infra-dev:mainfrom Jan 30, 2026
Merged
fix(shims): import.meta.url not being removed by tree-shaking#1463Timeless0911 merged 4 commits intoweb-infra-dev:mainfrom
import.meta.url not being removed by tree-shaking#1463Timeless0911 merged 4 commits intoweb-infra-dev:mainfrom
Conversation
import.meta.url not being removed by tree-shaking
Contributor
|
Thanks, can you update the test snapshots? |
Timeless0911
previously approved these changes
Jan 30, 2026
Timeless0911
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
当前版本，在开启
shims.esm.require后，即使未实际使用require，也会在产物中残留/*#__PURE__*/ import.meta.url;的代码。该代码会被 rspack 认为存在 side effect，导致 tree shaking 失效
修改后，此残留代码被移除。已验证不影响存在 require 的场景（含直接运行 rslib 产物、使用 rspack 在项目中二次打包 rslib 的产物）
In the current version, even if
requireis not actually used, the code/*#__PURE__*/ import.meta.url;will still remain in the code after enablingshims.esm.require. This code is considered by rspack to have a side effect, causing tree shaking to fail. After modification, this residual code has been removed.Related Links
Checklist