test: replace onDevCompileDone with onAfterDevCompile#1393
Merged
Timeless0911 merged 2 commits intomainfrom Dec 12, 2025
Merged
test: replace onDevCompileDone with onAfterDevCompile#1393Timeless0911 merged 2 commits intomainfrom
onDevCompileDone with onAfterDevCompile#1393Timeless0911 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the test configuration files by migrating from the deprecated onDevCompileDone API to the newer onAfterDevCompile API, and disables automatic browser opening during test runs to prevent interference with automated testing.
- Replaces all occurrences of
api.onDevCompileDone()withapi.onAfterDevCompile()across test configurations - Sets
server.opentofalseto prevent browser windows from opening during test execution - Updates test expectations to match the new configuration value
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/server/mf-dev/rslib.config.ts | Migrates plugin hook from onDevCompileDone to onAfterDevCompile and disables browser opening |
| tests/integration/server/index.test.ts | Updates test assertion to expect open: false instead of open: true |
| tests/integration/plugins/mf-dev/rslib.config.ts | Migrates two plugin hooks from onDevCompileDone to onAfterDevCompile |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDevCompileDonewithonAfterDevCompileRelated Links
Checklist