Skip to content

fix(dts): error log of set declarationDir when dts.build is true#1120

Merged
Timeless0911 merged 5 commits intomainfrom
fix/declar-logs
Jul 18, 2025
Merged

fix(dts): error log of set declarationDir when dts.build is true#1120
Timeless0911 merged 5 commits intomainfrom
fix/declar-logs

Conversation

@Timeless0911
Copy link
Copy Markdown
Contributor

Summary

Should always set declarationDir if outDir or declarationDir not meet dts emit path.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 18, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 31d57fa
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/6879e4a8caf6fc00084e394c
😎 Deploy Preview https://deploy-preview-1120--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a test case for the modification?

@Timeless0911
Copy link
Copy Markdown
Contributor Author

forget to commit...

@Timeless0911 Timeless0911 enabled auto-merge (squash) July 18, 2025 06:21
@Timeless0911 Timeless0911 merged commit eed450e into main Jul 18, 2025
14 checks passed
@Timeless0911 Timeless0911 deleted the fix/declar-logs branch July 18, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants