fix: outputDir is not working in webpack-plugin#1380
Merged
Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the outputDir configuration was not being properly set in the webpack plugin. The fix ensures that the output directory is correctly configured based on either the user-provided reportDir option or the compiler's outputPath, before writing the store.
Key Changes:
- Updated output directory configuration to be set dynamically in the
donemethod using compiler context - Added support for outside instances with parent SDK references
- Added comprehensive test coverage for various output directory scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/webpack-plugin/src/plugin.ts | Implements the core fix by setting outputDir in the done method with compiler.outputPath fallback and parent SDK support |
| packages/webpack-plugin/tests/outputDir.test.ts | Adds comprehensive test coverage for outputDir functionality across different plugin configurations |
| packages/webpack-plugin/tests/test-utils.ts | Updates import path for RsdoctorWebpackPluginOptions type definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
003a420 to
14ff91b
Compare
14ff91b to
4df27e1
Compare
9aoy
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: outputDir is not working in webpack-plugin
Related Links