chore: delete the useless info for lynx#1213
Merged
Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a specific warning message for the "lynx" compiler that advised users to disable concatenateModules for accurate bundle size analysis in Rsdoctor.
- Removes lynx-specific configuration warning about concatenateModules
- Simplifies the plugin's done hook by eliminating conditional warning logic
Comments suppressed due to low confidence (1)
packages/rspack-plugin/src/plugin.ts:225
- The removal of the lynx-specific warning lacks documentation explaining why this warning is no longer needed. Consider adding a comment or updating documentation to explain if lynx support has been dropped or if the concatenateModules issue has been resolved.
if (this.outsideInstance && 'parent' in this.sdk) {
9aoy
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chore: delete the useless info for lynx
Related Links