fix: the reportCodeType when mode:lite#1192
Merged
Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the reportCodeType behavior when using mode: 'lite' by simplifying the logic to always return NoSourceAndAssets for lite mode, regardless of the noAssetsAndModuleSource setting. The change also moves the noCode check to the beginning of the function for better precedence handling.
- Simplified lite mode logic to consistently return
NoSourceAndAssets - Reordered condition checks to prioritize
noCodesetting - Updated corresponding test expectations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/inner-plugins/utils/config.ts | Modified normalizeReportType function to simplify lite mode logic and reorder condition checks |
| packages/core/tests/build/utils/config.test.ts | Updated test expectations and added new test case for lite mode with noCode setting |
Comments suppressed due to low confidence (1)
packages/core/tests/build/utils/config.test.ts:50
- [nitpick] The test description 'should normalize output.reportCodeType and mode:lite' is unclear about what specific behavior is being tested. Consider a more descriptive name like 'should return NoCode when reportCodeType.noCode is true in lite mode'.
it('should normalize output.reportCodeType and mode:lite', () => {
9aoy
approved these changes
Jul 23, 2025
yifancong
added a commit
that referenced
this pull request
Jul 23, 2025
yifancong
added a commit
that referenced
this pull request
Jul 23, 2025
This reverts commit 0cee3bd.
yifancong
added a commit
that referenced
this pull request
Jul 23, 2025
This reverts commit 0cee3bd.
yifancong
added a commit
that referenced
this pull request
Jul 23, 2025
yifancong
added a commit
that referenced
this pull request
Jul 23, 2025
yifancong
added a commit
that referenced
this pull request
Aug 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: the reportCodeType when mode:lite.
Fix when in lite mode, the current reportCodeType is noSource, which should be noAssetsAndModuleSource.
Related Links