fix: resolve flickering issue in AssetCardContainer component#1191
Merged
yifancong merged 4 commits intoweb-infra-dev:mainfrom Jul 23, 2025
Merged
Conversation
- Replace array mapping with direct component rendering - Use selectedTitle state instead of index to prevent render inconsistency - Optimize onChange event handling for smoother user experience
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flickering issue in the AssetCardContainer component by refactoring the state management and rendering approach. The changes improve user experience by ensuring smoother transitions and preventing render inconsistencies.
- Replace index-based state with title-based state management to prevent flickering
- Optimize component rendering by eliminating unnecessary array mapping
- Improve onChange event handling for the Segmented component
Contributor
|
@QuentinHsu Thanks for your contribution! Please sign the license/CLA above. |
Contributor
Author
I have signed. |
yifancong
approved these changes
Jul 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
ref #1190