feat: replace lodash function with custom tool class Lodash#1035
Merged
yifancong merged 1 commit intoweb-infra-dev:mainfrom Apr 22, 2025
Merged
feat: replace lodash function with custom tool class Lodash#1035yifancong merged 1 commit intoweb-infra-dev:mainfrom
yifancong merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yifancong
previously approved these changes
Apr 22, 2025
yifancong
reviewed
Apr 22, 2025
Contributor
@wChenonly Yes, We can replace lodash with other tools that are more conducive to packaging volume. Thank you for your advice. |
f63bc74 to
0e0ac20
Compare
Contributor
Author
thanks，I'll deal with those in the next pr |
9d9b4c4 to
0e0ac20
Compare
0e0ac20 to
1f6d495
Compare
yifancong
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this pr has some simple lodash functions built in.
Now the use of internal lodash is relatively chaotic.
Also, I want to ask the person in charge, what's your attitude towards replacing lodash? Lodash hasn't been maintained for many years, and it's not efficient enough.
I want to use es-toolkit instead of it, if possible. Also, I don't need to switch to lodash-es for the existing lodash.
Related Links