Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces documentation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the new customLogger configuration option. The changes include new documentation pages in English and Chinese, updates to navigation, and cross-references from other relevant documents. The implementation is solid, but I have a couple of suggestions to improve the clarity of the new documentation pages by expanding the main description of the customLogger option.
There was a problem hiding this comment.
Pull request overview
Adds dedicated documentation for the customLogger config option (EN/ZH) and updates related docs/navigation so users can discover and use instance-scoped logging without mutating the shared global logger.
Changes:
- Add new
customLoggerconfig pages in English and Chinese, including recommendedcreateLogger()usage and global vs instance logger guidance. - Update
createLoggerAPI docs (EN/ZH) to mention it can be passed tocustomLogger. - Update config navigation and Vite migration docs (EN/ZH) to link to
/config/custom-logger.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/theme/rsbuildPluginOverview.ts | Adds customLogger entry to the config overview navigation. |
| website/docs/en/guide/migration/vite.mdx | Updates Vite→Rsbuild mapping table to link to the new customLogger config page. |
| website/docs/zh/guide/migration/vite.mdx | Updates Vite→Rsbuild mapping table to link to the new customLogger config page. |
| website/docs/en/config/custom-logger.mdx | New config doc page describing customLogger usage and logger access patterns. |
| website/docs/zh/config/custom-logger.mdx | New config doc page describing customLogger usage and logger access patterns. |
| website/docs/en/config/_meta.json | Adds custom-logger to config sidebar ordering. |
| website/docs/zh/config/_meta.json | Adds custom-logger to config sidebar ordering. |
| website/docs/en/api/javascript-api/core.mdx | Mentions createLogger() output can be used as customLogger. |
| website/docs/zh/api/javascript-api/core.mdx | Mentions createLogger() output can be used as customLogger. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as resolved.
This comment was marked as resolved.
Deploying rsbuild with
|
| Latest commit: |
85aa9b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f5e5fb6.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://codex-docs-custom-logger.rsbuild-v2.pages.dev |
Summary
customLoggerconfig docs, including recommendedcreateLogger()usage, global vs instance logger access, and version history.createLoggerAPI docs to mention that the created logger can be passed tocustomLogger.Related Links