chore: remove unused rspress-plugin-sitemap dependency#7352
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's dependencies by replacing a third-party sitemap plugin with its official counterpart. This change reduces the number of external dependencies and aligns the project with the recommended official plugin for sitemap generation within the Rspress ecosystem, potentially improving maintainability and consistency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Removes the legacy rspress-plugin-sitemap dependency from the website package now that the site uses the official Rspress sitemap plugin (@rspress/plugin-sitemap), reducing duplicate/unneeded dependencies for the docs site build.
Changes:
- Dropped
rspress-plugin-sitemapfromwebsite/package.json. - Pruned
rspress-plugin-sitemapentries frompnpm-lock.yaml.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/package.json | Removes the unused legacy sitemap plugin dependency from the website devDependencies. |
| pnpm-lock.yaml | Removes the corresponding lockfile entries for the dropped dependency. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying rsbuild with
|
| Latest commit: |
f0ffd5f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e4e01a7.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://remove-rspress-plugin-sitema.rsbuild-v2.pages.dev |
There was a problem hiding this comment.
Code Review
The pull request successfully removes the rspress-plugin-sitemap dependency and its related entries from pnpm-lock.yaml and website/package.json. This aligns with the summary of switching to the official sitemap plugin, which is already present in the configuration. The changes are straightforward and contribute to cleaning up unused dependencies.
Summary
Switched to https://rspress.rs/plugin/official-plugins/sitemap
Checklist