refactor: use helper for async file reading#6885
Merged
chenjiahan merged 3 commits intomainfrom Jan 4, 2026
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors async file reading to use a new readFileAsync helper function that standardizes filesystem operations using Rspack's filesystem APIs, replacing the use of Node's promisify utility.
Key changes:
- Introduces a new
readFileAsynchelper function inpackages/core/src/helpers/fs.ts - Replaces
promisify(fs.readFile)calls with the new helper across multiple files - Also refactors
zlib.gzipto use manual Promise wrapping instead ofpromisify
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/helpers/fs.ts | Adds new readFileAsync helper function that wraps Rspack filesystem's readFile in a Promise |
| packages/core/src/server/browserLogs.ts | Replaces promisify(fs.readFile) with readFileAsync for reading source maps |
| packages/core/src/rspack-plugins/RsbuildHtmlPlugin.ts | Replaces promisify(compilation.inputFileSystem.readFile) with readFileAsync for reading favicon files |
| packages/core/src/plugins/appIcon.ts | Replaces promisify(compilation.inputFileSystem.readFile) with readFileAsync for reading icon files |
| packages/core/src/plugins/fileSize.ts | Replaces promisify(zlib.gzip) with manual Promise wrapper for gzip compression |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new
readFileAsyncfunction to standardize async file reading using Rspack's filesystem, replacing the use ofpromisify.Checklist