Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds TypeScript type checking to the E2E CI workflow and updates the test runner from npm to pnpm. The changes include adding type annotations to a PostCSS plugin configuration file and modifying the GitHub Actions workflow to run the type checker after E2E tests.
Key changes:
- Added a new "Run E2E type checker" step to the e2e job in the CI workflow
- Updated test commands from
npm runtopnpm runfor consistency with the rest of the workflow - Added TypeScript type annotations to the PostCSS plugin configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/test.yml |
Added type checker step to e2e job and updated test commands from npm to pnpm |
e2e/cases/css/postcss-add-plugins/rsbuild.config.ts |
Added TypeScript type annotations to function parameters for type safety |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new "run type checker" step to the E2E job in the workflow to ensure type safety for E2E tests.
Checklist