fix: replace hardcoded Node.js built-ins with builtinModules#6865
Merged
chenjiahan merged 1 commit intomainfrom Dec 30, 2025
Merged
fix: replace hardcoded Node.js built-ins with builtinModules#6865chenjiahan merged 1 commit intomainfrom
builtinModules#6865chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces a hardcoded list of Node.js built-in module names with the official builtinModules array from Node.js's module package. This improves maintainability by relying on Node.js's own list rather than manually maintaining a potentially outdated hardcoded list.
Key changes:
- Imports
builtinModulesfromnode:modulepackage - Removes the hardcoded
nodeBuiltinsSet containing 45 module names - Simplifies the module check logic by using
builtinModules.includes()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the hardcoded
nodeBuiltinsset with thebuiltinModulesarray from the Node.jsmodulepackage, improving maintainability and accuracy.Related Links
Checklist