fix(create-rsbuild): use uppercase doctype in lit templates#6854
fix(create-rsbuild): use uppercase doctype in lit templates#6854chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR aims to standardize HTML templates in Lit projects by using uppercase DOCTYPE declarations and adding proper <html> wrapper tags. However, the implementation is incomplete as only one of three files correctly uses uppercase DOCTYPE.
Key changes:
- Updates HTML structure in three Lit template files to include
<html>wrapper tags - Attempts to change DOCTYPE from lowercase to uppercase
- Adds .prettierignore rule to prevent Prettier from formatting these HTML files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/create-rsbuild/template-lit-ts/src/index.html | Adds <html> wrapper and attempts DOCTYPE update (but uses lowercase) |
| packages/create-rsbuild/template-lit-js/src/index.html | Adds <html> wrapper and correctly uses uppercase DOCTYPE |
| examples/lit/src/index.html | Adds <html> wrapper and attempts DOCTYPE update (but uses lowercase) |
| .prettierignore | Adds ignore pattern for create-rsbuild HTML files (incomplete coverage) |
Critical Issue: There is an inconsistency in the DOCTYPE declarations across the three HTML files. While the PR title and description indicate the goal is to use "uppercase doctype", only template-lit-js/src/index.html correctly implements <!DOCTYPE html> with uppercase. The other two files (template-lit-ts/src/index.html and examples/lit/src/index.html) still use lowercase <!doctype html>. Additionally, the .prettierignore pattern doesn't cover the examples directory, which could lead to Prettier reformatting the examples/lit HTML file back to lowercase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
The same as #6853
Checklist