feat: improve display path for node_modules in error overlay#6845
Merged
chenjiahan merged 3 commits intomainfrom Dec 27, 2025
Merged
feat: improve display path for node_modules in error overlay#6845chenjiahan merged 3 commits intomainfrom
chenjiahan merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the display of file paths in the error overlay by standardizing how node_modules paths are shown, making stack traces cleaner and easier to read. The implementation extracts the package-relative path from potentially complex nested node_modules structures (e.g., pnpm's .pnpm directory).
Key changes:
- Introduces
formatDisplayPathfunction to standardize path formatting for error overlays - Formats nested node_modules paths (including pnpm's structure) to show only the last
node_modules/package/...portion - Maintains cross-platform support for both Unix and Windows path separators
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/server/overlay.ts | Adds formatDisplayPath function to handle node_modules path formatting and integrates it into convertLinksInHtml |
| packages/core/tests/overlay.test.ts | Adds comprehensive unit tests for the new formatDisplayPath function covering Unix, Windows, and pnpm scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize how file paths are shown in error overlay, especially for files inside
node_modules, making stack traces easier to read.Before
After
Checklist