perf: introduce cached trace map for stack parsing#6839
Merged
chenjiahan merged 1 commit intomainfrom Dec 26, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a performance optimization for browser error log formatting by implementing a caching mechanism for TraceMap objects. The cache reduces redundant file reads and TraceMap instantiations when parsing stack traces from browser errors.
- Introduced a
CachedTraceMaptype (Map<string, TraceMap>) to cache TraceMap instances by source map file path - Refactored
parseFramefunction to use the cache and avoid re-reading/re-parsing the same source maps - Updated function signatures throughout the call chain to thread the cache through
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/server/browserLogs.ts | Added CachedTraceMap type, refactored parseFrame to implement caching logic, and updated all related function signatures to accept and pass through the cache |
| packages/core/src/server/socketServer.ts | Creates a new cache instance per error handling session and passes it to formatBrowserErrorLog calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create and pass a
cachedTraceMapmap when formatting browser error logs and full stack traces, further reducing redundant file reads andnew TraceMap()during error handling.Before
After
Checklist