fix: should throw error when custom config file not found#6828
Merged
chenjiahan merged 4 commits intomainfrom Dec 23, 2025
Merged
fix: should throw error when custom config file not found#6828chenjiahan merged 4 commits intomainfrom
chenjiahan merged 4 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the behavior when a custom configuration file specified via --config is not found. Instead of logging a warning and falling back to default configuration, it now throws an error to make the failure explicit and prevent silent fallback behavior.
Key Changes
- Replaced
logger.warnwiththrow new Errorwhen a custom config file is not found - Added a test case to verify the error is thrown when a non-existent custom config is specified
- Minor indentation formatting improvements for code style consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/core/src/loadConfig.ts |
Changed resolveConfigPath to throw an error instead of logging a warning when a custom config file is not found; also includes minor formatting changes |
e2e/cases/cli/custom-config/index.test.ts |
Added test case to verify error is thrown when custom config file doesn't exist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
chenjiahan
reviewed
Dec 23, 2025
chenjiahan
reviewed
Dec 23, 2025
chenjiahan
approved these changes
Dec 23, 2025
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: should throw error when custom config file not found.
expect throw
config not founderror, but fallback to default config.before:
after:
Related Links
Checklist