Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit configuration of Rspack's optimization.inlineExports setting, as it's enabled by default in production builds and the explicit configuration is redundant.
- Removes the
chain.optimization.inlineExports(isProd)call from the basic plugin - Removes the unused
isProdparameter from the function destructuring - Updates all test snapshots to reflect the absence of the
inlineExportsconfiguration
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/plugins/basic.ts | Removes the explicit inlineExports configuration and the now-unused isProd parameter |
| packages/core/tests/snapshots/environments.test.ts.snap | Updates snapshots to remove inlineExports configuration from web and node environments |
| packages/core/tests/snapshots/default.test.ts.snap | Updates snapshots to remove inlineExports from development and production build configurations |
| packages/core/tests/snapshots/builder.test.ts.snap | Updates snapshot to remove inlineExports configuration |
| packages/core/tests/snapshots/basic.test.ts.snap | Updates snapshots to remove the optimization object that only contained inlineExports |
The code changes look good! The removal of the inlineExports configuration is appropriate since Rspack handles this automatically based on the build mode. The isProd parameter was correctly removed as it's no longer needed, and all test snapshots have been consistently updated to reflect these changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
No need to set Rspack's
optimization.inlineExportsconfig, it's enabled by default in production build.Related Links
Checklist