Skip to content

test(e2e): add runtime error overlay test#6814

Merged
chenjiahan merged 3 commits intomainfrom
runtime_errors_test_1221
Dec 21, 2025
Merged

test(e2e): add runtime error overlay test#6814
chenjiahan merged 3 commits intomainfrom
runtime_errors_test_1221

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Added a new E2E test that verifies runtime errors are shown in an overlay, including triggering a runtime error in the React app and asserting the overlay's appearance and content.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 21, 2025 10:06
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 21, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 72164cf
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6947c907ed7b520008d89639
😎 Deploy Preview https://deploy-preview-6814--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new E2E test to verify that runtime errors are properly displayed in the Rsbuild error overlay. The test validates that errors thrown during React component rendering appear in the overlay with appropriate messaging.

Key Changes

  • Added new runtime error overlay test that triggers a runtime error and validates overlay appearance
  • Cleaned up redundant assertions in the existing type-errors overlay test

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
e2e/cases/overlay/runtime-errors/index.test.ts New test file that verifies runtime error overlay behavior by introducing a runtime error and checking overlay content
e2e/cases/overlay/runtime-errors/src/index.jsx Basic React entry point for the runtime error test case
e2e/cases/overlay/runtime-errors/src/App.jsx Simple React component used as the test subject for triggering runtime errors
e2e/cases/overlay/runtime-errors/rsbuild.config.ts Rsbuild configuration enabling runtime error overlay functionality
e2e/cases/overlay/type-errors/index.test.ts Removed redundant assertions that were already covered by other checks in the test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit a367e66 into main Dec 21, 2025
11 checks passed
@chenjiahan chenjiahan deleted the runtime_errors_test_1221 branch December 21, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants