perf: avoid reading asset content from file system#6747
Merged
chenjiahan merged 2 commits intomainfrom Dec 10, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves build performance by avoiding file system reads when calculating asset sizes. Instead of reading asset content from disk using fs.readFile(), it directly accesses asset content from the webpack/rspack compilation object using stats.compilation.assets[n].source().
Key Changes:
- Replaced file system reads with in-memory asset access via compilation stats
- Inlined
PrintFileSizeAssettype definition (moved from helpers to config types) - Removed the now-unused
getAssetsFromStatshelper function
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/core/src/types/config.ts |
Moved PrintFileSizeAsset type definition from helpers/stats.ts and added documentation |
packages/core/src/server/middlewares.ts |
Simplified asset listing to use Object.keys() directly instead of the removed helper |
packages/core/src/plugins/fileSize.ts |
Core change: uses value.source() to get asset content from memory instead of fs.readFile() |
packages/core/src/helpers/stats.ts |
Removed RsbuildAsset type and getAssetsFromStats helper (no longer needed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid reading asset content from file system, use
stats.compilation.assets[n].value()instead.Before
After
Checklist