fix: use proper API to preserve source maps of inlined chunks#6734
Merged
chenjiahan merged 1 commit intomainfrom Dec 9, 2025
Merged
fix: use proper API to preserve source maps of inlined chunks#6734chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of source map preservation when inlining chunks by using the proper Webpack/Rspack API (updateAsset) instead of directly manipulating the compilation.assets object or calling compilation.deleteAsset without preparation.
Key Changes
- Introduced
hasSourceMapvariable to determine when source maps should be preserved - Replaced direct
delete compilation.assets[name]withcompilation.updateAsset()API to setrelated.sourceMaptonullbefore deletion - Now consistently uses
compilation.deleteAsset()for all asset removal operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
updateAssetto preserve source maps of inlined chunks.Calling
compilation.deleteAsset(name)is not recommended and may lead to unexpected behavior.Related Links
Checklist