test(hmr): refactor live-reload tests to use temp directory#6690
Merged
chenjiahan merged 1 commit intomainfrom Dec 3, 2025
Merged
test(hmr): refactor live-reload tests to use temp directory#6690chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the live-reload HMR tests to use isolated temporary directories instead of directly modifying source files, improving test isolation and reliability.
Key Changes
- Removed manual file backup/restore logic (
beforeEach/afterEachhooks) that was previously needed to preserve original source files - Integrated
copySrcDirhelper to create temporary test directories, ensuring each test run works with a clean, isolated copy - Updated dev server configuration to explicitly point to entry files in the temporary directory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor live reload tests to use
copySrcDirhelper to create temporary test directory instead of modifying original source files directly. This improves test isolation and reliability.Checklist