test(diagnostic): add test case for type warnings in console#6676
Merged
chenjiahan merged 1 commit intomainfrom Dec 1, 2025
Merged
test(diagnostic): add test case for type warnings in console#6676chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a test case to verify that TypeScript type warnings are printed in the browser console and updates the @rsbuild/plugin-type-check plugin to version 1.3.2.
- Adds new test case in
e2e/cases/diagnostic/type-warningsto verify async build warnings appear in browser console - Adds comprehensive test case in
e2e/cases/overlay/type-errorsto verify type error display in overlay - Updates
@rsbuild/plugin-type-checkfrom v1.3.1 to v1.3.2 (which includes dependencyts-checker-rspack-pluginupgrade from v1.2.0 to v1.2.1)
Reviewed changes
Copilot reviewed 5 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates @rsbuild/plugin-type-check to v1.3.2 and its dependency ts-checker-rspack-plugin to v1.2.1 |
| e2e/package.json | Updates @rsbuild/plugin-type-check dependency specification to ^1.3.2 |
| e2e/cases/diagnostic/type-warnings/* | New test case that verifies TypeScript warnings (TS2322) appear in browser console |
| e2e/cases/overlay/type-errors/* | New test case that verifies type errors display correctly in the error overlay UI |
| e2e/cases/overlay/disabled/* | New test case that verifies error overlay can be disabled via configuration |
| e2e/cases/overlay/basic/* | New test case that verifies basic error overlay functionality |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rsbuild/plugin-type-checkto v1.3.2Related Links
Checklist